search

openshiftio / openshift.io

Red Hat OpenShift.io is an end-to-end development environment for planning, building and deploying modern applications.
https://openshift.io
97 stars 66 forks source link

Dynamic fields lose unsaved values on work item update #3951

Open rgarg1 opened 6 years ago

rgarg1 commented 6 years ago

A question for the UX team....

Consider the following scenario:

  1. User open work item quick preview
  2. Enters some value on a dynamic field like Story points. Doesn't saves the value yet
  3. Edits the iteration of the work item. This causes the work item to reload and the storypoints entered earlier by the user are lost.

So, is it okay to lose data in the dynamic fields on an update, or the data must be retained is the question.

rgarg1 commented 6 years ago

Cc @Veethika @divyanshiGupta

kwk commented 6 years ago

@rgarg1

So, is it okay to lose data in the dynamic fields on an update, or the data must be retained is the question.

It is absolutely NOT okay to discard the entered data!

Veethika commented 6 years ago

@rgarg1 if the user has edited any field in the quick preview panel and has not committed to it or saved it, the moment they perform an action that calls for the closing of the panel, a warning should appear asking them to commit to the change or discard it.

rgarg1 commented 6 years ago

Thanks @Veethika and @kwk for your suggestions.

Given the inputs, this becomes a defect in Planner UI.

muruGanesan commented 6 years ago

@rgarg1, I believe this issue is closed or addressed from the UX side. If yes, you can remove UX labels.

@Veethika, @AshishDurgude, @sunilmalagi, @sdash-redhat, would you like to capture this UX recommendation as part of UX standards in our design wiki?

rgarg1 commented 6 years ago

Done @muruGanesan

muruGanesan commented 6 years ago

thanks @rgarg1

joshuawilson commented 6 years ago

This is still an issue.

kwk commented 6 years ago

I consider this a high priority because of Data loss.

nimishamukherjee commented 5 years ago

a warning should appear asking them to commit to the change or discard it.

@openshiftio/uxd-team please provide a visual of the warning. cc @Veethika @sunilmalagi

joshuawilson commented 5 years ago

I don't think we need a warning as much as auto-save. When you leave the field it should save the information.

rgarg1 commented 5 years ago

+1 to @joshuawilson

nimishamukherjee commented 5 years ago

I don't think we need a warning as much as auto-save. When you leave the field it should save the information.

@Veethika @serenamarie125 please comment ^^

divyanshiGupta commented 5 years ago

@Veethika is the UX ready for this?

joshuawilson commented 5 years ago

@divyanshiGupta for now, you can just auto-save it. That is the normal use of a form.

divyanshiGupta commented 5 years ago

@joshuawilson okay :+1:

christianvogt commented 5 years ago

@Veethika if we implement auto save, do you still want to have an ok button along side the cancel? In this case now the ok button does the same as navigating away. Will users expect that their input is saved if they don't press ok? Maybe they enter a value and think it will be discarded if they don't press ok and are surprised it gets saved.

christianvogt commented 5 years ago

Btw I think the original issue was that editing a separate field causes data lose in an unsaved field. This is indeed a bug. The user should have the ability to go back to the first field and save or discard the value. Instead the value was thrown away unexpectedly. It had nothing to do with closing the panel.

Veethika commented 5 years ago

Btw I think the original issue was that editing a separate field causes data to lose in an unsaved field. This is indeed a bug. The user should have the ability to go back to the first field and save or discard the value. Instead, the value was thrown away unexpectedly. It had nothing to do with closing the panel.

@christianvogt Right, my solution swayed towards the opening and closing the panel which should be addressed in a different story altogether. For this issue, the work-item should not be reloaded everytime a user begins to edit a field. But the state of the fields has to be maintained for a 'session' if I'm not wrong. So are we referring to end of the session as 'until another work item is selected'(the content of quick preview changes)?

christianvogt commented 5 years ago

@Veethika @joshuawilson I believe this issue is exactly the same as I logged here: https://github.com/openshiftio/openshift.io/issues/4643

What we do if the user chooses to navigate away is a separate issue. But when editing the same issue, we are losing data. If we fix this problem, do we still need an auto save? Or a warning about navigating away?

joshuawilson commented 5 years ago

@christianvogt can you close #4643 as a duplicate?

divyanshiGupta commented 5 years ago

What we do if the user chooses to navigate away is a separate issue. But when editing the same issue, we are losing data. If we fix this problem, do we still need an auto save? Or a warning about navigating away?

@Veethika what is the suggested UX?

divyanshiGupta commented 5 years ago

Unassigning myself as I am not working on this issue currently as I have some other tasks on priority.