When promoting app from stage to run, dialog is displayed for fraction of a second

openshiftio / openshift.io

Red Hat OpenShift.io is an end-to-end development environment for planning, building and deploying modern applications.

https://openshift.io

97 stars 66 forks source link

When promoting app from stage to run, dialog is displayed for fraction of a second #4017

Open ldimaggi opened 6 years ago

ldimaggi commented 6 years ago

Steps to recreate:

Create new app in Openshift.io launcher
Press "input required" button to deploy app to run
Observe small dialog displayed for fraction of a second:
After which it is overwritten by the promote dialog:

myimage

hrishin commented 6 years ago

@ldimaggi this is happening because dialog box checks if Jenkins is running and not idle before enabling those buttons. What improvement are we expecting here? Better UX?

ldimaggi commented 6 years ago

Can we hide that additional dialog? It's confusing to see it displayed for only a fraction of a second.

piyush-garg commented 6 years ago

@ldimaggi If Jenkins is in the idle state, then it will be there for a long time until it does not get unidle. This box was introduced for that purpose only.

ldimaggi commented 6 years ago

So - if Jenkins is not idle - then the dialog is only displayed very quickly, correct? Is it possible to check if Jenkins is idle, and if it is not, then not display the dialog?

hrishin commented 6 years ago

@ldimaggi

Jenkins is idle, and if it is not, then not display the dialog?

Sorry didnt get that.

hrishin commented 6 years ago

Jenkins is idle, and if it is not, then not display the dialog?

@ldimaggi I think this dialogue is needed, however, we can try to enhance the overall UX around it. i.e. UI can keep the active state of Jenkins (idle or not idle) by polling it or using watch request on Jenkins deployment. In that way, UI would not poll Jenkins each and every time while opening the dialogue box.

@joshuawilson @ldimaggi are we planning any enhancements here?

joshuawilson commented 6 years ago

Eng doesn't have any current plans to change this. However, if @openshiftio/uxd-team provides direction here we can add it to the backlog.

piyush-garg commented 5 years ago

@joshuawilson @ldimaggi @hrishin

This seems like a UI improvement and needs recommendations from the UX team. Nothing build team can do with this. Removing build team label and adding UX label

cc @sthaha @muruGanesan @pradeepto

muruGanesan commented 5 years ago

@piyush-garg, @joshuawilson @ldimaggi @hrishin, The 'gif' animation (attachment) appears like an experience issue. But when I tested with my application (pipeline), I found a huge delay in activating Jenkins. so I don't get a chance to see the second pop-up at all.

I suggest two corrections: 1) Visual interference: pop-up window's height changes abruptly - this can be fixed immediately.

2) Technical & experience issue: we (UX) team should discuss with the relevant engineering team and decide on an appropriate solution.

cc @sthaha @pradeepto, @serenamarie125

joshuawilson commented 5 years ago

I would agree that making them the same size makes sense. Please let us know what else should be changed.

muruGanesan commented 5 years ago

@joshuawilson, thanks. I would like to understand the following: 1) what happens, if we promote or reject the build without invoking Jenkins?

joshuawilson commented 5 years ago

Promote and reject are actions against Jenkins. If Jenkins isn't there and you click the button it should fail with an error code that indicates Jenkins is down. There is no way to click those, have them work and not call Jenkins.

muruGanesan commented 5 years ago

@joshuawilson, thanks. I too discussed with @hrishin about the same point. [It is difficult to separate UI from the Jenkins status] Considering the above scenario, we can do only the visual enhancement i.e. height, width, and the display position of both pop-ups/dialog boxes should be same.

CC: @piyush-garg, @christianvogt @ldimaggi @hrishin,@sthaha @pradeepto, @serenamarie125