search

openshiftio / openshift.io

Red Hat OpenShift.io is an end-to-end development environment for planning, building and deploying modern applications.
https://openshift.io
97 stars 66 forks source link

Toggle button should not call analytics scan API #4150

Open yzainee-zz opened 6 years ago

yzainee-zz commented 6 years ago

Currently when the toggle button ( cve_notification) is enabled in the UI, it triggers an API call to the analytics scan. The toggling of the button should not call any scan. The scan is supposed to be called only from the build flow.

Refer to this conversation for more details: https://chat.openshift.io/developers/pl/47c71f8eoirc9ngaz6tmbesk8c.

nurali-techie commented 6 years ago

@yzainee is it SEV2? What I understand is it's making extra call which need to be stopped. It's not blocking any user for using functionality.

miteshvp commented 6 years ago

@nurali-techie - do you see any challenges in blocking that extra call?

yzainee-zz commented 6 years ago

@aslakknutsen Closing this issue as we will be handling this issue in our backend. @miteshvp This will be lots of changes in the platform side, lets handle it in our code.

aslakknutsen commented 6 years ago

remove everything around the gemini service from wit https://github.com/fabric8-services/fabric8-wit/tree/master/codebase/analytics-gemini and everything around it. Just store the CVEScan bool on Codebase as a bool and nothing more.

nurali-techie commented 6 years ago

PR is merged but changes will NOT apply to prod-preview until this is fixed https://gitlab.cee.redhat.com/dtsd/housekeeping/issues/2349