openshiftio / openshift.io

Red Hat OpenShift.io is an end-to-end development environment for planning, building and deploying modern applications.
https://openshift.io
97 stars 66 forks source link

[f8a] repo_dependency_finder: AttributeError: 'set' object has no attribute 'get' #4156

Closed msrb closed 6 years ago

msrb commented 6 years ago

https://errortracking.prod-preview.openshift.io/openshift_io/fabric8-analytics-production/issues/6589/

AttributeError: 'set' object has no attribute 'get'
  File "celery/app/trace.py", line 375, in trace_task
    R = retval = fun(*args, **kwargs)
  File "celery/app/trace.py", line 632, in __protected_call__
    return self.run(*args, **kwargs)
  File "selinon/task_envelope.py", line 169, in run
    raise self.retry(max_retries=0, exc=exc)
  File "celery/app/task.py", line 668, in retry
    raise_with_context(exc)
  File "selinon/task_envelope.py", line 114, in run
    result = task.run(node_args)
  File "f8a_worker/base.py", line 106, in run
    raise exc
  File "f8a_worker/base.py", line 81, in run
    result = self.execute(node_args)
  File "f8a_worker/workers/repo_dependency_finder.py", line 50, in execute
    repo_cves = self.create_repo_node_and_get_cve(github_repo, dependencies)
  File "f8a_worker/workers/repo_dependency_finder.py", line 73, in create_repo_node_and_get_cve
    for pkg in deps_list.get('direct'):
msrb commented 6 years ago

cc @samuzzal-choudhury @abs51295

abs51295 commented 6 years ago

This isn't a bug. It's basically happening because of an npm repository (https://github.com/gorkem/penfold) being tested for CVEs and subscribed to security alerts on prod. We don't support node for security alerts for end users. This is more of a feature request rather than a bug.

msrb commented 6 years ago

@abs51295 fair enough, but I'd expect the task to fail gracefully if given ecosystem is not supported yet :)

abs51295 commented 6 years ago

@ravsa I will take this from here :)

abs51295 commented 6 years ago

@msrb this will be taken care of once experimental endpoint is in production, we won't be using worker flows then 😉 .

msrb commented 6 years ago

@abs51295 ack, feel free to close this bug :wink: