search

openshiftio / openshift.io

Red Hat OpenShift.io is an end-to-end development environment for planning, building and deploying modern applications.
https://openshift.io
97 stars 66 forks source link

"Search for a space" from My Spaces can displace scrollbar #4269

Open andrewazores opened 6 years ago

andrewazores commented 6 years ago
Issue Overview

When appropriately sized, the My Spaces page will display a standard scroll bar. If the "Search for a space" toolbar button is clicked and the modal dialog appears, this scroll bar may disappear, causing the background (My Spaces view) to shift slightly. When the modal is dismissed the scroll bar may reappear, which shifts My Spaces back. This behaviour has been reproduced in Chromium/Chrome but not Firefox.

Expected Behaviour

The scroll bar should either always show or always hide, regardless of modal show/hide state.

Current Behaviour

The scroll bar may hide when the modal is shown and vice-versa.

Steps To Reproduce
  1. Open Chrome/Chromium browser
  2. Navigate to My Spaces (top left menu > My Spaces)
  3. Resize browser window so scroll bar appears
  4. Click "Search for a space" toolbar button. If it does not appear, ensure Feature Opt-In in User Settings is set to Experimental, and retry this step.
  5. Observe scroll bar becomes hidden
  6. Dismiss dialog
  7. Observe scroll bar becomes shown
aptmac commented 6 years ago

FWIW, this is intentional on the Bootstrap side of things [0].

Having said that, I played around a little bit with this, and if the overflow value is set to scroll then the scrollbar will persist. However, the body gets appended with a modal-open attribute and padding-right: 15px styling. open (note the gap on the pf-toolbar) gap It's also interesting to note that when the modal hides, it resets this value, but leaves a padding-right: 0px on the body. closed

joshuawilson commented 5 years ago

Is this still an issue after the changes you made?

andrewazores commented 5 years ago

Yes, although after Alex's comment above this may be a WONTFIX deal if it's an intentional Bootstrap quirk/feature.