openshiftio / openshift.io

Red Hat OpenShift.io is an end-to-end development environment for planning, building and deploying modern applications.
https://openshift.io
97 stars 66 forks source link

If github is down or unreachable, an error should be raised in OSIO when user attempts to create project #4479

Open ldimaggi opened 6 years ago

ldimaggi commented 6 years ago
Issue Overview

See issue #4473 - in the event that github is not available, no error is reported to the user in the OSIO UI.

Tell us briefly what the problem is about. On October 21/22, issue #4473 illustrated a problem where if github is unreachable, no error is returned in the OSIO UI. A permissions error is written to the browser console log.

Expected Behaviour

If an error occurs, a user would expect to see an error raised int he OSIO UI.

Current Behaviour

No error is displayed in the OSIO UI.

Steps To Reproduce
  1. See issue #4473
Additional Information
joshuawilson commented 6 years ago

@openshiftio/uxd-team Please review.

serenamarie125 commented 6 years ago

@joshuawilson @christianvogt @catrobson what do we do when OpenShift is not accessible? I'm wondering if we should use a similar mechanism as OpenShift Online does - display System Status in the top banner. Thoughts?

joshuawilson commented 6 years ago

makes sense to me

joshuawilson commented 6 years ago

But the question is about github, not OpenShift. I think for OpenShift being down we need the System Status. Is the same true for github? You can still build and plan.

christianvogt commented 6 years ago

@serenamarie125 @joshuawilson A system status and / or status of dependent systems makes sense. But parts of the app are still functional and we need to handle these failure cases much more gracefully across the UI.

joshuawilson commented 6 years ago

agreed

serenamarie125 commented 5 years ago

Agreed that we need to handle these issues gracefully.

@joshuawilson I know this issue is about GH, not OpenShift, but I was asking about how we display the fact that OpenShift isn't available to the user, to evaluate if we should use a similar pattern.

@christianvogt are we able to identify all the areas which need GH availability? If so, upon user action, we could proactively check if GH is available, and if not, display an appropriate message. I think this would be a better solution then trying to perform the action, and then erroring out and displaying the message.

christianvogt commented 5 years ago

@serenamarie125 I was thinking that if we have a notification panel or something this is where we can put this type of information as soon as the user enters the app.

Sure we could compile a list of all areas that require GH.

If we already know that GH, or any other dependent system is down, we could indicate that actions aren't available.

ldimaggi commented 5 years ago

@christianvogt Giving the users that type of information when they login would be a big help - and it would also be much simpler than trying to provide real-time updates on the health and accessibility of external systems on which we depend.

joshuawilson commented 5 years ago

Providing it initially makes sense, but what if you have been using it all day. I can go days without logging out. It should also appear when we make a call to the service and it is down. Unless we have some status widget that regularly checks and updates it's self.

serenamarie125 commented 5 years ago

I'd suggest showing an icon in the masthead to indicate system status which can impact the use of the product. Github being down or unreachable are just 2 things which could attribute an icon being displayed in the masthead.

Users should be able to click on the icon to get more information displayed in a popover.

joshuawilson commented 5 years ago

@serenamarie125 at one point a status widget in the masthead was designed. Can you see if they still exist?