openshiftio / openshift.io

Red Hat OpenShift.io is an end-to-end development environment for planning, building and deploying modern applications.
https://openshift.io
97 stars 66 forks source link

Add the remaining build notifications to MatterMost to complement the existing ones. #557

Closed burrsutter closed 6 years ago

burrsutter commented 7 years ago

We need an ongoing/real-time "report" of changes happening to the production environment. This would allow end-users (those watching MM) to know that elements A, B or C have been updated recently, they might wish to close and re-open their incognito browser session and likely clean/Update Tenant depending on what changed. They also know to quickly report issues related to the component that was updated. For instance, today, we have noticed the Applications Tab stopped responding and that the Create Space dialog box has trouble closing.

cctrieloff commented 7 years ago

showing out update stream to production would be a great transparency feature.

rafabene commented 7 years ago

We need to be more DevOps oriented and everytime that there is a new version of a new component we should see it also in the Dashboard. Each new version should have:

bmicklea commented 7 years ago

There should also be an indication as to whether tenant update or browser refresh / clear is required (or any other manual user action).

rawlingsj commented 7 years ago

We currently have hubot slack notifications in the fabric8 pipelines which send updates / requests for interaction during releases. I added a hubot mattermost image a little while back which in theory can be switched in place of our slack one but I've not tested it yet.

One issue would be that fabric8 pipelines do everything apart from the actual production tenant deployment ATM but this is something I'm sure we can figure out. In short this shouldn't be too hard to do.

ldimaggi commented 7 years ago

+1 to notifications of when the user should perform a tenant update, or browser refresh. Maybe something along the lines of how eclipse informs users that updates are available?

joshuawilson commented 7 years ago

@rawlingsj you want me to set up a MM channel for it? I don't know that we want it in the main channel.

rawlingsj commented 7 years ago

@joshuawilson thanks, we can hold off setting up the MM channel until ready to try it out which is unlikely to be this week.

rawlingsj commented 7 years ago

Just another thought on this; I wonder if there's two things here, one short term another which might be more involved but could be a great feature...

  1. short term send chat (mattermost) notifications when new tenant updates are available
  2. long term have a more advanced info messaging feature, maybe like a stackoverflow type thing where folks can asynchronously get updates about new releases / features + notifications

Does that sound useful?

bmicklea commented 7 years ago

@rawlingsj +1. For your number 2 above some kind of automated message that explains the release version and includes a link to release notes and changelog would be ideal.

rawlingsj commented 7 years ago

some kind of automated message that explains the release version and includes a link to release notes and changelog would be idea.

Yeah exactly that! It would also be a pretty nice way to let folks know about experimental features, how to toggle them on/off etc.

joshuawilson commented 7 years ago

The problem is this is a SaaS not a product that lives by a release schedule. The best you can do is compile a list of the commits as they happen across all the repos that are brought together to form the service.

bmicklea commented 7 years ago

What happened with this? Was it completed? If so what's the MM channel name?

joshuawilson commented 7 years ago

@bmicklea last week @rawlingsj was working on getting it set up on MM. I believe he needed a few things set in place and it should be working early this week.

rawlingsj commented 7 years ago

@joshuawilson @bmicklea last week I validated we can receive the existing hubot pipeline notifications in mattermost (we currently get them in slack). I now have an internal issue requesting MM config changes which we need to enable these notifications https://gitlab.cee.redhat.com/dtsd/housekeeping/issues/524.

FWIW this doesn't include notifications when new tenant versions are available for the tenant service to deploy. This will require a bit more work and until the internal issue above is resolved I'm not planning on doing anything more with our chatops features.

joshuawilson commented 7 years ago

What needs to be done next? Is what we have enough?

kbsingh commented 7 years ago

the push-to-prod has been reported to mattermost for the last 8 months or so. Check servicedel channel for traffic from openshiftio BOT

edit: reread this thread, this is scoped to just the gke hosted builds for now, majority of the content is already notified in mattermost. Keeping this open, but reassigning to James to execute, he should have the webhook needed for the inbound notify.

rawlingsj commented 7 years ago

reassigning back to you @kbsingh as I'm still waiting for the token as per the email :)

kbsingh commented 7 years ago

unsure why we need the user-token, the other 40 odd integrations have not needed it. There is no schedule to get user-tokens onboarded, so we should block / close this issue for now.

rawlingsj commented 7 years ago

we use hubot as the integration which requires a personal access token so notifications can be sent from the fabric8 bot.

rawlingsj commented 7 years ago

Is this issue a severity P1? as @kbsingh mentions its just the pipeline notifications that aren't going to MM yet, prod deployments done by centos ci are being done.

joshuawilson commented 7 years ago

The severity/priority was set by @burrsutter. If he doesn't respond, then maybe @rafabene or @qodfathr can comment.

rafabene commented 7 years ago

I don't think it should be P1, but I'll defer to @burrsutter

rawlingsj commented 7 years ago

As it happens I think this is still pretty important. We really do need to have the pipeline notifications in mattermost.

joshuawilson commented 7 years ago

@rawlingsj based on your demo this appears done. Is there something else that needs to be done or can we close this?

rawlingsj commented 7 years ago

@kbsingh which mattermost channel are the prod deployment events being sent to? I've had a little look but cant find them, once we know that yeah I think this issue can be closed.

qodfathr commented 6 years ago

@kbsingh looks like the last question before we can close was directed at you.

kbsingh commented 6 years ago

content is reported to the servicedel channel