Deleting a space doesn't delete associated pipelines

[joshuawilson]

From @joshuawilson on May 22, 2017 1:56

From @fbricon on May 2, 2017 15:22

After deleting a space, I still have a zombie pipeline still trying to build. It's possible the pipeline state is in a borked state that prevents it from being deleted, I have no idea, but in that case the deletion process should be more robust.

Copied from original issue: openshiftio/openshift.io#132

Copied from original issue: fabric8-ui/fabric8-ui#1344

[joshuawilson]

From @jstrachan on June 14, 2017 8:45

I guess this is a UX question; should deleting a space delete all Pipelines & Apps in that space? Or move them to some other space? Maybe the space deletion wizard needs to present the user with that choice?

Delete space cheese

This space contains the following resources which will be deleted:

Delete 3 pipelines too? Y/N
Delete 2 applications in Stage and Run Y/N?

Or you can move those resources to a different Space?

etc?

[joshuawilson]

From @jstrachan on June 14, 2017 8:46

Or the simple solution - don't allow a Space to be deleted until you delete all the Pipelines + Apps?

[joshuawilson]

@fabric8io/uxd @catrobson please review for design of deleting spaces. @jstrachan do we have an API to remove pipelines and apps?

[joshuawilson]

From @jstrachan on June 14, 2017 21:8

Yeah, we've all the APIs we need in the openshift REST API.

Once we get the UX figured out I can implement it pretty easily. I might add a basic option for now with a couple of checkboxes & we can iterate with the UX

[joshuawilson]

sounds good, we need this and can adjust when the designs come in

[joshuawilson]

From @catrobson on June 14, 2017 21:48

Adding @qodfathr to the thread to get some input on expectations when deleting a space. There are many things that a space contains that could either be migrated to another space or deleted upon deleting a space. Is there an expectation around this from the PM standpoint on what we should be supporting?

[joshuawilson]

related to #1252 #1197 #1251

[joshuawilson]

From @qodfathr on June 29, 2017 21:7

There are a lot of considerations to be made here, and many equally valid and competing use-cases. We'll need to do some UX research, but, based upon even some back of the napkin use-casing, I feel that we essentially need to offer the user a list of everything which is associated with the Space (pipelines, repos, etc.), each with a checkbox. The checkbox controls "delete this thing, too."

Simple use case A: I make a new space "foo", use a quickstart, and now have both a "foo" repo and a "foo" pipeline. Then I decide it was a mistake to make it. I likely want to delete everything with one operation.

Simple use case B: I make a new space "foo" and import an existing "foo" repo. A pipeline is created for me. The I decide it was a mistake to create it. I likely want to delete the space and perhaps the pipeline, but definitely not the repo. (Because it was pre-existing.)

Maybe the logic should be a set of checkboxes, with the checkboxes defaulted to checked (meaning "delete this, too") for those items which were created by OSIO? In other words, in use case A, everything would be defaulted to checked -- Space, Pipeline and Repo. But in use case B, only Space and Pipeline would be checked by default.

[joshuawilson]

From @ldimaggi on June 30, 2017 15:51

Issue was originally logged here: https://github.com/fabric8-ui/fabric8-ui/issues/1251

[joshuawilson]

From @ldimaggi on June 30, 2017 15:51

Closing 1251 as a dup of this issue.

[joshuawilson]

This falls under User-Story #478

[qodfathr]

I think this is fixed, but the circular loop of GitHub issue linkages is making me question my memory. @joshuawilson , thoughts?

[joshuawilson]

@ldimaggi I haven't set up my spaces for this in a while. Have you seen this?