search

openshmem-org / specification

OpenSHMEM Application Programming Interface
http://www.openshmem.org
50 stars 38 forks source link

2D team split behavior when xrange > npes #326

Closed davidozog closed 4 years ago

davidozog commented 4 years ago

@jdinan and I ran into a minor implementation problem when testing a 2D team split with xrange > npes here: https://github.com/davidozog/sandia-shmem/pull/9

Perhaps I'm missing something in my interpretation of the API description, but I'm not sure it's explicit about this case. Do we create an "unfilled" xteam (similar to the unfilled yteams when npes(parent_team) % xrange > 0), or should we require that xrange be less than or equal to the number of PEs in the parent team?

For what it's worth, I think it's a bit more self-consistent to create the unfilled xteam; but it's also simpler to just require xrange <= npes. Any thoughts?

naveen-rn commented 4 years ago

duplicate of https://github.com/gmegan/specification/issues/122

jdinan commented 4 years ago

@naveen-rn Thanks for the reference. Now that teams is merged, I suggest that we move issues to the openshmem-org repository, so that we can better track them relative to the OpenSHMEM 1.5 release.

nspark commented 4 years ago

I'm happy to work with @davidozog on suggesting a clarifying note to the Teams section committee.