openshmem-org / specification

OpenSHMEM Application Programming Interface
http://www.openshmem.org
50 stars 38 forks source link

Update formatting on Profiling examples #343

Closed nspark closed 4 years ago

nspark commented 4 years ago

This PR builds on #237—the only commit unique to this PR is d2e61b8—but is significant enough to not be strictly editorial. It updates the example listings to use the new macros, but slightly adjusts the caption text to suit the new structure.

Thus, commit d2e61b8 will need approval by the Profiling Interfaces Section Committee (@jlinford, @agrippa, @wrrobin, @swpoole). (Viewing the diff while hiding whitespace changes is most clear, as there were trailing spaces that were removed.)

wrrobin commented 4 years ago

Thanks @nspark. The changes look good. Can we also update the pshmem_example as James suggested on #237? Not sure whether this can be a doc edit though.

nspark commented 4 years ago

Thanks @nspark. The changes look good. Can we also update the pshmem_example as James suggested on #237? Not sure whether this can be a doc edit though.

I think we should leave that change to the Section Committee to change in the coming weeks. I'd like to get the rest of the example changes in today, ideally.

agrippa commented 4 years ago

LGTM

jdinan commented 4 years ago

@nspark Could you please rebase or merge with master so the diff is easier to review? Given the stage we are at now, my preference would be to avoid any more changes directly on master and instead merge this into the section committee's branch.

nspark commented 4 years ago

@jdinan Rebased as requested!

nspark commented 4 years ago

That should be fine, but it's up to @jlinford, @agrippa, and @wrrobin

wrrobin commented 4 years ago

This is fine with me although, I am not aware of any section branch for profiling interfaces.

jdinan commented 4 years ago

@jlinford Is the profiling interfaces section chair.

wrrobin commented 4 years ago

@nspark Can you please create the PR against wrrobin:sec/profiling-interface?

nspark commented 4 years ago

Replaced by https://github.com/wrrobin/specification/pull/3