Closed minsii closed 3 years ago
@davidozog Can you please review this PR?
Make sure these changes are also merged upstream in the main SOS repository or they will get lost with the next release update.
@davidozog Thanks for reviewing. Using the multiplier allows us to keep different trails for small/large messages, and we don't need set different trails for different tests. The main reason to use SOS_TRIALS_MULTIPLIER
in our test framework is that we run multiple jobs on a single machine. So we just want to reduce trails for all tests to shorten the run time.
@minsii - yeah, I suppose it makes sense to have just 1 knob to dial all tests longer or shorter based on the default values.
I suppose I'll take over merging this change into tests-sos and submitting a PR into SOS master and v1.4.x, unless you prefer to @minsii?
@minsii Would it be helpful if we add the multiplier in our argument list rather than reading it from the env var?
Test framework can adjust the value of trials through environment variable SOS_TRIALS_MULTIPLIER (default 1, float).