search

openshmem-org / tests-sos

Sandia OpenSHMEM unit tests and performance testing suite
Other
6 stars 11 forks source link

Sync with SOS v1.5.1 #23

Closed davidozog closed 2 years ago

davidozog commented 2 years ago

This updates a majority of the tests to use OpenSHMEM v1.5 APIs.

As usual, everything has been reviewed and tested on the SOS side, but this PR could certainly use a sanity check. Perhaps @yfguo, @hzhou, @jdinan, or @rzambre are users of these tests? Is OSHMPI still including tests-sos in its testing?

If I recall correctly, the v1.4.x branch is most useful to existing implementations. I don't believe there is anything here that needs to be included in v1.4.x, but please let me know if you find anything, or if there are existing issues we can look at for v1.4.

yfguo commented 2 years ago

@davidozog We are still using tests-sos in our testing for OSHMPI. Let me try with this PR and get back to you.

davidozog commented 2 years ago

@davidozog We are still using tests-sos in our testing for OSHMPI. Let me try with this PR and get back to you.

Awesome, thanks @yfguo! Does OSHMPI support the v1.5 APIs? Or are the tests primarily run against the v1.4.x branch? I suspect you might find several problems testing this PR without teams support, for example.

yfguo commented 2 years ago

@davidozog We are still using tests-sos in our testing for OSHMPI. Let me try with this PR and get back to you.

Awesome, thanks @yfguo! Does OSHMPI support the v1.5 APIs? Or are the tests primarily run against the v1.4.x branch? I suspect you might find several problems testing this PR without teams support, for example.

We mostly testing against 1.4.x. We have teams implemented, but team-based collective is still WIP.

rzambre commented 2 years ago

Thanks for letting us know of the update. There should be no blockers from ROC_SHMEM. We manually translate a subset of the SOS tests to test ROC_SHMEM's host interface. So, we will just scan this update for any changes to existing tests and consider the new ones.

davidozog commented 2 years ago

I believe we are ready to merge this. Before we do, please let me know if you have run into any problems (esp. @yfguo @rzambre). We plan to merge later this week.

@yfguo - I see that OSHMPI cannot build all the updated tests (i.e, "make check" fails), so it might be useful to add a configure option to disable certain collections of tests (like team-based collectives, non-blocking atomics, etc.) for now. Would this feature be of interest? It might create a tiny bit more maintenance on the SOS team, but I think it could be helpful for other implementations updating to v1.5+.