search

openshmem-org / tests-sos

Sandia OpenSHMEM unit tests and performance testing suite
Other
6 stars 11 forks source link

Add shmemx_wtime fadd_nbi. #26

Closed yfguo closed 9 months ago

yfguo commented 2 years ago

fadd_nbi is missing the definition of shmemx_wtime when building with external library that does not have it. Adding it the same way as other unit tests.

davidozog commented 1 year ago

I'm sorry @yfguo I either did not receive a notification about this pull request, or I simply missed it. Is it still an issue that needs resolving on your end?

I think this problem is a bit more pervasive across the SOS unit tests, for example bcast_flood, big_get, big_put, lfinc.c, and spam all rely on shmemx_wtime. Perhaps we can put this definition into a new header file in SOS/tests/include/wtime.h or something like that? Then include it in the tests that need it?

It also would help to make this change to SOS itself since this repo is meant to mirror the SOS unit tests (as much as possible).

I can help make the change if needed, but it may take a little time... :)