search

openshmem-org / tests-sos

Sandia OpenSHMEM unit tests and performance testing suite
Other
6 stars 11 forks source link

Add tests for IBPUT/IBGET #35

Closed philipmarshall21 closed 4 months ago

philipmarshall21 commented 6 months ago

This PR adds tests for the IBPUT/IBGET APIs (currently shmemx extensions, but ratified and to be included in a later OpenSHMEM spec version).

philipmarshall21 commented 6 months ago

@wrrobin It may be good to add Bryan, Mark, and Parker as contributors to this repo as well

wrrobin commented 5 months ago

@philipmarshall21 - This looks good. One comment is that when we move these interfaces to shmem from shmemx, the test cases can be merged with c11_test_shmem_get/put.c and cxx_test_shmem_get/put.cpp rather than separate ones.

philipmarshall21 commented 5 months ago

@philipmarshall21 - This looks good. One comment is that when we move these interfaces to shmem from shmemx, the test cases can be merged with c11_test_shmem_get/put.c and cxx_test_shmem_get/put.cpp rather than separate ones.

Yep, totally agree!

philipmarshall21 commented 5 months ago

Approved. Please take care of the minor comments.

Recommended changes have been applied. Not sure that I should merge just yet. The SOS CI would fail when trying to build the new tests because the function declarations are not present in shmemx.h (except in the SOS PR that adds ibput/ibget implementation). May be best to wait until SOS PR 1114 is reviewed and ready to be merged. Then we could merge this PR, run the CI on PR 1114 once more and merge it