search

openshmem-org / tests-sos

Sandia OpenSHMEM unit tests and performance testing suite
Other
6 stars 11 forks source link

Classify CXX generic tests as shmemx tests #4

Closed jdinan closed 5 years ago

jdinan commented 5 years ago

@minsii With this patch, you should no longer need to disable C++ tests in OSHMPI testing. Could you please let me know if this resolved the issue on your end?

minsii commented 5 years ago

Thanks, Jim ! We will try it soon and let you know.

Min

Sent from my iPhone

On Nov 15, 2018, at 12:54 PM, James Dinan notifications@github.com<mailto:notifications@github.com> wrote:

Merged #4https://github.com/openshmem-org/tests-sos/pull/4 into master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/openshmem-org/tests-sos/pull/4#event-1969475250, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA272vjy9KHK5j5IOH-EAvBXFCIoILfaks5uvbhbgaJpZM4YegPG.

minsii commented 5 years ago

I just tested. It works without --disable-cxx. Thanks, @jdinan.

Instead of moving all cxx tests to shmemx, it will be useful if we could have some cxx tests that use standard APIs in test/unit. If this works for you, we can contribute a PR for it .

jdinan commented 5 years ago

Always happy to accept your PRs. This patch should have only gated the type-generic C++ tests on the --enable-shmemx configure option. The cxx_test_shmem_complex test should still be run.