search

openshmem-org / tests-sos

Sandia OpenSHMEM unit tests and performance testing suite
Other
6 stars 11 forks source link

Deprecation fixes and cleanup #41

Open davidozog opened 4 months ago

davidozog commented 4 months ago

Some unit tests still rely on deprecated APIs/constants, so this PR separates those out. They can be enabled at configure time with --enable-deprecated-tests.

This also corrects the version number to 1.5.2 and disables Fortran tests by default. They can be enabled at configure time with --enable-fortran.

davidozog commented 4 months ago

@markbrown314 - I thought I saw a comment about checking for NULL pointers in email. Was it deleted by chance? Seemed like a good catch to me...

markbrown314 commented 4 months ago

@markbrown314 - I thought I saw a comment about checking for NULL pointers in email. Was it deleted by chance? Seemed like a good catch to me...

I noticed that not checking for NULL pointer returns were all over the codebase. If we want to clean this up it might need to have it's own PR.

markbrown314 commented 4 months ago

@davidozog Since this Deprecation fix patch set did not introduce the n_loops issue I mentioned earlier, I will open a cleanup PR to address this issue and some other issues I found (such as no NULL return pointer checking, etc.). I will approve this change.