search

openshmem-org / tests-sos

Sandia OpenSHMEM unit tests and performance testing suite
Other
6 stars 11 forks source link

Improve context creation failure in tests #5

Closed jdinan closed 5 years ago

jdinan commented 5 years ago

Merge changes from https://github.com/Sandia-OpenSHMEM/SOS/pull/802

jdinan commented 5 years ago

@minsii Please let me know if this resolves the contexts issues that you encountered with OSHMPI. If there's an easy way to do it, it would also be great to incorporate OSHMPI testing in the Travis CI script for tests-sos.

minsii commented 5 years ago

@jdinan Thanks for making the changes for us ! @huansong has confirmed that the failing tests under test/unit work with OSHMPI now.

However, we also notice that you add context error checking for the performance tests. We actually test all unit, perf and app tests for OSHMPI. With this change, the following tests fail with OSHMPI:

FAIL: shmem_bw_put_ctx_perf
FAIL: shmem_bw_put_ctx_perf_nb
FAIL: shmem_bibw_put_ctx_perf
FAIL: shmem_bibw_put_ctx_perf_nb
FAIL: shmem_latency_put_ctx_perf
FAIL: shmem_latency_put_ctx_perf_nb
FAIL: shmem_latency_get_ctx_perf
FAIL: shmem_latency_get_ctx_perf_nb

Do you think the default context can be also used in these tests if shmem_ctx_create returns error ?

minsii commented 5 years ago

It would be great to have OSHMPI in tests-sos Travis CI script ! Maybe we can create a simple build script in https://github.com/pmodels/oshmpi.git similar to scripts/simple-build-ofi.sh. So the tests-sos Travis script can directly wget it and install OSHMPI.