Old models DisplayGeometry lose transform on upgrade

opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.

https://opensim.stanford.edu

Apache License 2.0

796 stars 320 forks source link

Closed aymanhab closed 8 years ago

aymanhab commented 8 years ago

Noted while trying to visualize double_pendulum.osim from repository/master in API visualizer and latest GUI

aymanhab commented 8 years ago

This boils down to this:

Earlier conversions of DisplayGeometrty that had extra transform was creating intermediate Frames and "connecting" Geometry to it.
The change to use attached_geometry assumed no transform between the frame and its attached Geometry. The fix is likely to locate the intermediate frame and attach to it but it's not clear yet how to locate that intermediate frame during deserialization.

aymanhab commented 8 years ago

This has been fixed by PR #1299 Sorry I missed it earlier. Please close.