Update CI to use MacOS 12

opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.

https://opensim.stanford.edu

Apache License 2.0

783 stars 316 forks source link

Update CI to use MacOS 12 #3604

Closed nickbianco closed 11 months ago

nickbianco commented 11 months ago

Fixes issue #

Brief summary of changes

Testing I've completed

Looking for feedback on...

CHANGELOG.md (choose one)

no need to update because...
updated.

This change is

nickbianco commented 11 months ago

@aymanhab, @AlbertoCasasOrtiz, I noticed the recent Mac builds have been failing because package installs with Homebrew were taking a very long time (4+ hours). MacOS 11 is no longer officially supported, so I'm testing the CI using MacOS 12.

aymanhab commented 11 months ago

Sounds good @nickbianco will keep an eye. One thing to keep in mind is that regardless of github position, we need to check if the build runs on osx11 machines (as some users maybe stuck there).

nickbianco commented 11 months ago

@aymanhab, the change seems to be working as intended (aside from some minor failures in testMocoInverse, which I can address). Do we know anyone still using MacOS 11? The official EOL was in September, so I'd say it's reasonable to upgrade to the oldest version still supported by Apple.

aymanhab commented 11 months ago

@nickbianco I think 3 yrs is long enough lag for users to upgrade, so I wouldn't hold development progress for these rare cases. There're other CMake variables related to osx version that may allow this build to still run on earlier versions anyway, so I'm good with the change once tests are passing. 👍

nickbianco commented 11 months ago

Merging, thanks @aymanhab.