A possible typo in `OrigDataStartFrame` metadata value

opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.

https://opensim.stanford.edu

Apache License 2.0

783 stars 316 forks source link

A possible typo in `OrigDataStartFrame` metadata value #3648

Open mrrezaie opened 9 months ago

mrrezaie commented 9 months ago

Hi, the value for OrigDataStartFrame metadata key in TRC files generated by TRCFileAdapter (tables from c3d files) is set to 0 which doesn't make sense. Because frames cannot be started from zero. I think it must be 1 here in line 327:

https://github.com/opensim-org/opensim-core/blob/e565abfc88a1c3c3031cae9fc0866924460b687d/OpenSim/Common/TRCFileAdapter.cpp#L320-L328

However, it is trivial.

mrrezaie commented 3 months ago

Hi, the Mokka software prints this warning when opening a TRC file generated by OpenSim API: ... Impossible to set the first frame to 0 or lower.