opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.
https://opensim.stanford.edu
Apache License 2.0
783 stars 316 forks source link

Add rule-of-five to `IKMarkerTask` and `OrientationWeightSet` #3657

Closed nickbianco closed 9 months ago

nickbianco commented 9 months ago

Brief summary of changes

Adds move constructors, copy assignment operators, and move assignment operators to IKMarkerTask and OrientationWeightSet. This suppresses gcc compiler warnings complaining about no user-defined assignment operator when a user-defined copy-assignment operator is present.

ProbeMeasure issues a similar warning, but I think it can be ignored. It uses a Simbody macro to define custom copy assignment operators and copy constructors. The macro uses the terms shallowAssign and deepAssign to define its copy constructors, since these do not use the typical constructor syntax, gcc complains.

Testing I've completed

CHANGELOG.md (choose one)


This change is Reviewable

nickbianco commented 9 months ago

Thanks @aymanhab!