opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.
https://opensim.stanford.edu
Apache License 2.0
783 stars 316 forks source link

Removes musclePower field from MuscleDynamicsInfo #3665

Closed pepbos closed 8 months ago

pepbos commented 9 months ago

This PR removes the musclePower field from the cached MuscleDynamicsInfo.

Since the cache's main purpose is to store expensive-to-compute results, and the muscle power is very cheap to compute, it can be removed from the cache.

Brief summary of changes

Testing I've completed

Unit tests are passing, and contain regression tests for several muscles.

CHANGELOG.md


This change is Reviewable

pepbos commented 8 months ago

@adamkewley , @tkuchida thanks for your comments! I think it is good to merge, but have a look if you have the time