opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.
https://opensim.stanford.edu
Apache License 2.0
759 stars 308 forks source link

[WIP] Fix `Model::extendConnectToModel` graph traversal #3697

Closed adamkewley closed 4 months ago

adamkewley commented 5 months ago

WIP

⚠️ This is a bigger diff than reality

This work is Related to #3694 . The diff here will be smaller once #3694 is merged. Otherwise, this PR will be refactored into an independent patch.

(I was too lazy to break this branch away from the feature branch, is what I'm trying to say).


This is to fix some of the bugs I've noticed in the multibody graph traversal part of OpenSim. Notably:

Brief summary of changes

Testing I've completed

Looking for feedback on...

CHANGELOG.md (choose one)


This change is Reviewable

adamkewley commented 4 months ago

Closing: the problem this fixes is mostly fixed by the #3711 patch