search

opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.
https://opensim.stanford.edu
Apache License 2.0
758 stars 308 forks source link

Add `get_GeometryPath` as a wrapper function for `getGeometryPath` in OpenSim 4.5 #3732

Closed cvhammond closed 3 months ago

cvhammond commented 3 months ago

It seems that OpenSim 4.5 has removed get_GeometryPath() from the core library and associated MATLAB wrapper. Can you please add get_GeometryPath() as a wrapper for getGeometryPath() so as to ensure backwards compatibility for anyone who is migrating from OpenSim 4.4 to OpenSim 4.5?

tkuchida commented 3 months ago

(See PR #3535 and upgrade notes for v4.5 in CHANGELOG.md.)

nickbianco commented 3 months ago

Hi @cvhammond, getGeometryPath() is compatible with both OpenSim 4.4 and 4.5.

The get_ syntax is typically reserved for property methods, the unnamed property GeometryPath was removed in favor of the named property path of type AbstractGeometryPath. See the PR linked above for more details.

nickbianco commented 3 months ago

I added a note to the OpenSim 4.5 release notes on Confluence.

nickbianco commented 3 months ago

@cvhammond, thanks again for bringing this up, but since we do have the backwards compatible option we do not plan to add this wrapper for the reasons stated above.