Fix rFindIndex returns invalid index (#3743) - Githubissues

opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.

https://opensim.stanford.edu

Apache License 2.0

758 stars 308 forks source link

Fix rFindIndex returns invalid index (#3743) #3748

Closed adamkewley closed 3 months ago

adamkewley commented 3 months ago

Fixes issue #3743

Brief summary of changes

Fixes bad reverse_iterator.base() logic in the reverse search (should subtract 1 from result)

Testing I've completed

Added test that fails due to bad implementation
It failed
Changed implementation with guidance from (e.g.) https://stackoverflow.com/questions/24997910/get-index-in-vector-from-reverse-iterator
It passed

Looking for feedback on...

CHANGELOG.md (choose one)

no need to update because internal bugfix

This change is