search

opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.
https://opensim.stanford.edu
Apache License 2.0
758 stars 308 forks source link

Fix set Array element at last slot and beef test case accordingly build-gui #3753

Closed aymanhab closed 3 months ago

aymanhab commented 3 months ago

Fixes issue #0 build-gui [build-gui]

Brief summary of changes

Setting 0th entry for an Array of size 1 resulted in a change of size to 2 and basically acted as insert.

Testing I've completed

Beefed test case for Array that was failing before the code change and now passes. GUI build with the fix doesn't exhibit the problem anymore.

Looking for feedback on...

CHANGELOG.md (choose one)

This change is Reviewable

aymanhab commented 3 months ago

build-gui

adamkewley commented 3 months ago

Oh god, this Array stuff is coming back to haunt me @aymanhab - sorry about this! - looks good to merge etc!

aymanhab commented 3 months ago

No worries at all @adamkewley and thanks for the quick turnaround 👍