opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.
https://opensim.stanford.edu
Apache License 2.0
758 stars 307 forks source link

Update testMuscles.cpp to use Catch2 #3819

Closed AllisonJohn closed 5 days ago

AllisonJohn commented 6 days ago

Fixes part of issue #3555

Brief summary of changes

Minimally converted testMuscles to Catch2 testing system. The 3 commented out tests (that fail) were also converted but still commented out.

Testing I've completed

The 5 tests still pass

Looking for feedback on...

if the header comments are accurate

CHANGELOG.md (choose one)

no need to update because it's just for internal testing


This change is Reviewable

AllisonJohn commented 5 days ago

Just noting that someone wrote "@param startX the starting position of the muscle anchor. I have no idea why this value is included" in the simulateMuscle header

nickbianco commented 5 days ago

Great work @AllisonJohn!