opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.
https://opensim.stanford.edu
Apache License 2.0
758 stars 307 forks source link

TimeSeriesTable method trimToIndices is now public, added tests #3824

Closed AllisonJohn closed 3 days ago

AllisonJohn commented 4 days ago

Fixes issue #3751

Brief summary of changes

Moved trimToIndices method from protected to public. Updated its error handling. Wrote tests for trim, trimTo, trimFrom, and trimToIndices in testDataTable

Testing I've completed

The dataTable tests

Looking for feedback on...

The error handling for when the table could be empty, indices out of bounds

CHANGELOG.md (choose one)


This change is Reviewable