search

opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.
https://opensim.stanford.edu
Apache License 2.0
800 stars 323 forks source link

Add force Outputs to `ExpressionBasedCoordinateForce` and `ExpressionBasedPointToPointForce` #3872

Closed nickbianco closed 3 months ago

nickbianco commented 3 months ago

Brief summary of changes

Adds Outputs to access forces computed in ExpressionBasedCoordinateForce and ExpressionBasedPointToPointForce.

(Apologies for all of the whitespace trimming changes from my IDE.)

Testing I've completed

Added tests to testForces.cpp.

Looking for feedback on...

CHANGELOG.md (choose one)

This change is Reviewable

nickbianco commented 3 months ago

FYI @stingjp @mattpetrucci

nickbianco commented 3 months ago

Nice 😎 Just curious: why not include ExpressionBasedBushingForce ?

Other than laziness? No 😅

Added an Output for ExpressionBasedBushingForce now, which needed some additional changes.

nickbianco commented 3 months ago

Thanks @AllisonJohn and @tkuchida!

@mattpetrucci, @stingjp, this is now ready for testing.