opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.
https://opensim.stanford.edu
Apache License 2.0
800 stars 323 forks source link

Update continuous_integration.yml to re-enable java tests on windows #3885

Closed aymanhab closed 3 months ago

aymanhab commented 3 months ago

Reenable java tests on windows

Fixes issue #

Brief summary of changes

Testing I've completed

Looking for feedback on...

CHANGELOG.md (choose one)


This change is Reviewable

aymanhab commented 3 months ago

@nickbianco I think nothing changed there, windows2019 successfully builds/runs java tests and windows2022 builds but fails to load the libraries

aymanhab commented 3 months ago

Try to address issue #3806 apparently the "recommened" solution was to a remove a dll from the jdk installation, what a mess!

nickbianco commented 3 months ago

Try to address issue https://github.com/opensim-org/opensim-core/issues/3806 apparently the "recommened" solution was to a remove a dll from the jdk installation, what a mess!

Yikes.

nickbianco commented 3 months ago

@aymanhab, do you want to merge this to have the Java tests enabled for Windows 2019 for now?

aymanhab commented 3 months ago

Yes I think it's good to run the javs tests on some windows environment

aymanhab commented 3 months ago

Thanks @nickbianco