Fix matlab tests - Githubissues

opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.

https://opensim.stanford.edu

Apache License 2.0

800 stars 323 forks source link

Fix matlab tests #3886

Closed aymanhab closed 1 month ago

aymanhab commented 3 months ago

Fixes issue #0

Brief summary of changes

fix 2 matlab test cases ta\hat fail locally

Testing I've completed

ran tests locally and they pass, one failure left Matlab_MocoWorkflow_Release though the problem solves, may need a look by @nickbianco to understand the issue

Looking for feedback on...

CHANGELOG.md (choose one)

no need to update because Matlab tests are not exposed to users

This change is

aymanhab commented 1 month ago

@nickbianco This should fix the lingering matlab test failures for developers who happen to have matlab locally installed. Also to make our published codebase/tests consistent with our own API. Not urgent since broken for years..

aymanhab commented 1 month ago

Thanks @nickbianco The old test was using plain equality of doubles after performing transformation/matrixt multiplication!

aymanhab commented 1 month ago

Thanks @nickbianco 👍