opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.
https://opensim.stanford.edu
Apache License 2.0
801 stars 324 forks source link

Add fixes and enhancements related to `MocoGeneralizedForceTrackingGoal` #3887

Closed nickbianco closed 3 months ago

nickbianco commented 3 months ago

Brief summary of changes

The exampleMocoTrack subexample using MocoGeneralizedForceTrackingGoal did not work out-of-the-box due to changes in the source code that were not propagated to the example files. The example failed because setWeightForGeneralizedForce expected a generalized force name (e.g., "ankle_angle_r_moment") but was currently being given only the coordinate name. This PR fixes this inconsistency and includes the following improvements:

Testing I've completed

Ran exampleMocoTrack locally.

Looking for feedback on...

CHANGELOG.md (choose one)


This change is Reviewable

nickbianco commented 3 months ago

Thanks @AllisonJohn and @carmichaelong!