Closed adamkewley closed 2 months ago
Do you think it's worth it to upgrade this to a Socket?
Not in this particular case: the class is a plain C++ class, rather than an OpenSim::Component
, so it doesn't have (e.g.) the socket table that's used to store socket declarations - it's essentially an internal struct for the C++ API that seems to mostly just be used by GeometryPath
Thanks for the comments @nickbianco and @tkuchida - I've addressed them as best as possible, including rewriting some of the documentation.
Since this is a minor change, I'll go ahead and merge it, rather than doing multiple rounds
Minor clean-up. The motivation for doing so is that I'm currently working on a new
ForceEmitter
base class, which can re-usePointForceDirection
, rather than (e.g.) having to introduce its own point-force holding class.Fixes issue N/A
Brief summary of changes
virtual
destructor. It's unused codebase-widescale
feature. It's unused inopensim-core
, which uses the magnitude ofdirection
to encode the forcefinal
qualifier to the class, which will cause all code that was inheritingPointForceDirection
to no longer compile, which is a requirement for removing the virtual destructorGeometryPath
Testing I've completed
Looking for feedback on...
CHANGELOG.md (choose one)
final
and[[deprecated]]
changes. Unlikely to affect downstream users.This change is