search

opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.
https://opensim.stanford.edu
Apache License 2.0
800 stars 323 forks source link

Set flags for Moco dependencies on Linux and MacOS build scripts #3913

Closed nickbianco closed 1 month ago

nickbianco commented 1 month ago

Fixes issue #3839

Brief summary of changes

Sets the CMake variables OPENSIM_WITH_CASADI and OPENSIM_WITH_TROPTER in the opensim-core builds for both the Linux and MacOS build scripts.

Testing I've completed

Ran both build scripts locally.

Looking for feedback on...

CHANGELOG.md (choose one)

This change is Reviewable

AlbertoCasasOrtiz commented 1 month ago

I will mark as completed as they finish:

@nickbianco Everything seems to work properly on a clean VM with Ubuntu 22.04, however, I do not have a Mac machine to test right now.

nickbianco commented 1 month ago

I tested the script on my Mac machine and these changes worked, so I think we're okay to merge.

nickbianco commented 1 month ago

The Windows failure seems unrelated (spdlog issue).

AlbertoCasasOrtiz commented 1 month ago

I agree, we can merge. Also the script passed CI for Mac.