Closed nickbianco closed 4 weeks ago
@nickbianco For the record the LD_LIBRARY_PATH changes appear to have been lost before the python tests are run on ubuntu. If everything else passes though then feel free to merge and I will take it on.
@aymanhab, gotcha. As discussed, we can come back around to this later to resolve the Python testing issues on Ubuntu.
Installing the Mac Arm64 build into a local conda environment fails. @aymanhab, thoughts? Looks like the rpaths are not being set correctly?
Python 3.10.15 (main, Oct 3 2024, 02:24:49) [Clang 14.0.6 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import opensim as osim
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/nbianco/miniconda3/envs/zmp/lib/python3.10/site-packages/opensim/__init__.py", line 18, in <module>
from .simbody import *
File "/Users/nbianco/miniconda3/envs/zmp/lib/python3.10/site-packages/opensim/simbody.py", line 10, in <module>
from . import _simbody
ImportError: dlopen(/Users/nbianco/miniconda3/envs/zmp/lib/python3.10/site-packages/opensim/_simbody.so, 0x0002): Library not loaded: @rpath/libosimExampleComponents.dylib
Referenced from: <35EB33C3-F08F-3BC8-A249-794230C5E39D> /Users/nbianco/miniconda3/envs/zmp/lib/python3.10/site-packages/opensim/_simbody.so
Reason: tried: '/Users/nbianco/miniconda3/envs/zmp/lib/python3.10/site-packages/opensim/libosimExampleComponents.dylib' (no such file), '/Users/nbianco/miniconda3/envs/zmp/lib/python3.10/site-packages/opensim/../../../sdk/lib/libosimExampleComponents.dylib' (no such file), '/Users/runner/work/opensim-core/opensim-core-install/sdk/lib/libosimExampleComponents.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/work/opensim-core/opensim-core-install/sdk/lib/libosimExampleComponents.dylib' (no such file), '/Users/nbianco/miniconda3/envs/zmp/lib/python3.10/site-packages/opensim/../../../sdk/Simbody/lib/libosimExampleComponents.dylib' (no such file), '/Users/runner/work/opensim-core/opensim-core-install/sdk/Simbody/lib/libosimExampleComponents.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/work/opensim-core/opensim-core-install/sdk/Simbody/lib/libosimExampleComponents.dylib' (no such file), '/Users/nbianco/miniconda3/envs/zmp/lib/python3.10/site-packages/opensim/libosimExampleComponents.dylib' (no such file), '/Users/nbianco/miniconda3/envs/zmp/lib/python3.10/site-packages/opensim/../../../sdk/lib/libosimExampleComponents.dylib' (no such file), '/Users/runner/work/opensim-core/opensim-core-install/sdk/lib/libosimExampleComponents.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/work/opensim-core/opensim-core-install/sdk/lib/libosimExampleComponents.dylib' (no such file), '/Users/nbianco/miniconda3/envs/zmp/lib/python3.10/site-packages/opensim/../../../sdk/Simbody/lib/libosimExampleComponents.dylib' (no such file), '/Users/runner/work/opensim-core/opensim-core-install/sdk/Simbody/lib/libosimExampleComponents.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/work/opensim-core/opensim-core-install/sdk/Simbody/lib/libosimExampleComponents.dylib' (no such file), '/Users/nbianco/miniconda3/envs/zmp/bin/../lib/libosimExampleComponents.dylib' (no such file), '/Users/nbianco/miniconda3/envs/zmp/bin/../lib/libosimExampleComponents.dylib' (no such file)
@nickbianco Conda makes some assumptions about layout. When we build conda package, the conda build system modifies rpaths accordingly. I'd test installing in non conda environment using setup.py etc. but not sure conda would work out of the box. I'd also test java/matlab Just let me know what you want me to try/test to get this over the finish line
Yeah, it looks like python -m pip install .
doesn't install the .dylib
s anywhere in the conda environment. I'll try a different install approach and see what I get.
Using a Python venv
fails too: nothing is copied into the /lib
folder of the venv
.
@aymanhab, this is ready for review. I didn't test the "Build GUI" workflow; let me know if you'd like that tested as well.
Would be good to test just for completeness though it has no dependencies on ci scripts.
@aymanhab, the GUI build job fails, I think because a personal access token needs to be added or updated. It's up to you if you consider that blocking here.
Thanks for trying it out @nickbianco Definitely not blocking, will review accordingly.
As discussed, the Ubuntu 22 failure is unrelated and the GUI build job will be resolved in a future PR.
Thanks @aymanhab!
Fixes issue #3944
Brief summary of changes
continuous_integration.yml
to include separate jobs for Mac x64 and Arm64 architectures.WrapEllipsoid
related to indexing a Mat44 that was causing the Ubuntu 22 job to fail.Testing I've completed
Ran the CI, and ran both the Windows and Mac performance analysis workflows.
Looking for feedback on...
CHANGELOG.md (choose one)
Performance analysis
Platform: Mac, GitHub Actions runner
This change is