Closed aymanhab closed 2 weeks ago
Python tests restored on linux
@aymanhab, the tests are still commented out. Perhaps you forgot to push a commit?
The tests are run as part of the test step rather than separately and they pass as far as I can tell.
@aymanhab, ah, good point. It looks like all the Python tests are run via ctest
. So I think we can remove the "Test Python bindings" step from all the CI jobs?
Thanks @nickbianco I'll remove the commented out lines and merge then. What may be good to have is a test of python in packaged form not in install environment. This could be done by adding a conda repository build which would be useful on its own. Thoughts? I will work on that but that's unrelated to PR.
@aymanhab, there are also "Test Python bindings" steps in the Windows and Mac jobs: are these redundant with the ctest
runs?
What may be good to have is a test of python in packaged form not in install environment. This could be done by adding a conda repository build which would be useful on its own. Thoughts? I will work on that but that's unrelated to PR.
Agreed, we should have some dedicated testing of the conda packages somewhere.
Sure, I'll remove these tasks for Windows and Mac.
@nickbianco I thought about this a little more, let's discuss before we either merge or remove the rest. I'm now working on the optional automated conda build upon push.
@nickbianco Per our discussion I restored the test of installed layout on linux and all tests pass now.
Thanks @nickbianco
Export LD_LIBRARY_PATH right before running python tests
Fixes issue #3950
Brief summary of changes
Testing I've completed
Looking for feedback on...
CHANGELOG.md (choose one)