opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.
https://opensim.stanford.edu
Apache License 2.0
800 stars 323 forks source link

Initialize the texture string property previously unused. #3961

Closed aymanhab closed 1 week ago

aymanhab commented 2 weeks ago

Fixes issue #0

Brief summary of changes

SurfaceProperties (used to support visualization) had an optional property of texture that was never used, now I'm trying to use it but it appears the initialization of the property was missing. Adding it back.

Testing I've completed

Looking for feedback on...

CHANGELOG.md (choose one)


This change is Reviewable

aymanhab commented 1 week ago

Pretty trivial but necessary change to serialize texture string, needed now to test textures, will populate defaults in a later PR to modify xml comment.

aymanhab commented 1 week ago

Thanks @nickbianco 👍 I guess a property that is never used can do without constructProperty since nobody tries to access it.