Fix Point Kinematics Reporter Variable Error

opensim-org / opensim-core

SimTK OpenSim C++ libraries and command-line applications, and Java/Python wrapping.

https://opensim.stanford.edu

Apache License 2.0

800 stars 323 forks source link

Fix Point Kinematics Reporter Variable Error #3966

Open alexbeattie42 opened 1 week ago

alexbeattie42 commented 1 week ago

Brief summary of changes

Fix Point Kinematics Reporter Variable Error

Testing I've completed

Tested locally

Looking for feedback on...

CHANGELOG.md (choose one)

This change is

nickbianco commented 1 week ago

Good find @alexbeattie42! Could you add a changelog entry, since this could affect behavior for users who might not have realized that setRelativeToBody was working incorrectly.

It would be nice to add some unittests for PointKinematics in testAnalyzeTool.cpp, if you're feeling up for it.

alexbeattie42 commented 1 week ago

I can try to take a look at adding some test cases. I'm not very familiar with the testing framework used in the project (I believe it's catch2) but I'll give it a shot.

nickbianco commented 6 days ago

Thanks @alexbeattie42! Catch2 is pretty straight-forward, but let me know if you have any questions.