opensim-org / opensim-gui

SimTK OpenSim graphical user interface and distribution.
Apache License 2.0
61 stars 32 forks source link

On Mac, clicking ">" in Analysis Edit window should expand the tree. #516

Open aseth1 opened 6 years ago

aseth1 commented 6 years ago

I loaded /Models/Gait2354_Simbody/subject01_Setup_Analyze.xml in the AnalyzeTool GUI and was able to see the analyses (like Kinematics, Actuation and BodyKinematics) with "all" listed and was unable to edit them. This was with OpenSim 2112110-2018-01-31.

aymanhab commented 6 years ago

Can you check if this is Mac specific @jimmyDunne or @tkuchida ? Thanks

tkuchida commented 6 years ago

Tested with AppVeyor artifact OpenSim-dd7dc47b-2018-02-11.zip. I don't know whether @aseth1 means that the fields were disabled, the cursor appeared in the Value box after double-clicking but the string couldn't be edited, the "OK" button didn't work, the values reverted back to their original values, etc. Steps to reproduce, expected result, and actual result would be helpful. I presume his steps to reproduce would be as follows:

I selected BodyKinematics, double-clicked the box beside step_interval, replaced "10" with "5", pressed <Enter>, and clicked "OK". No issues encountered, and the value remained "5" after clicking Edit again.

The following did not work:

Perhaps the start_time and end_time are determined by the Time range to process fields on the Main Settings tab. If so, then these fields should not be editable on the Analyses tab.

aymanhab commented 6 years ago

Names can be edited and saved/serialized on windows no problem, will check on osx

aymanhab commented 6 years ago

Cant reproduce on osx either with local build, likely issue is a bit of confusion due to UI differences on osx:

chrisdembia commented 6 years ago

I just tested this with Mac OpenSim c596914-2018-02-24 using steps similar to what @tkuchida listed and the result was similar to what @tkuchida observed.

  1. The only fields that did not preserve their values were start_time and end_time.
  2. For Kinematics, I was able to add and delete coordinates and my changes were preserved after clicking "OK" and then "Edit" again.
  3. @aymanhab I did notice that I had to double click and that clicking the ">" was not sufficient. However, this is not a bug, not Mac-specific behavior (I have verified this statement in Finder).
  4. After a while, the GUI crashed; see this crash log: OpenSim c596914-2018-02-24CrashLogIssue516.txt
aymanhab commented 6 years ago

@chrisdembia I think this issue is misnamed or has been fixed. I agree that editing on osx is unfriendly and we know there's a crash on cancel (signature OpenSim::[Kinematics]::assign) in callstack. Editing start-endtime is cross platform and separate issue.

chrisdembia commented 6 years ago

@aymanhab I tested this because it appears on the Needs Verifying board. ~I suggest closing this issue.~

EDIT: I will rename the issue.