Handle isDisabled removal from Component

[aymanhab]

Previously GUI was leveraging the isDisabled property for common code to enable/disable Forces, Constraints and Controllers. Now removed from API in Alpha release.

[jenhicks]

If this is not completed yet, would be nice to have done in time for ISB. I think lower priority than some other tasks unless it will be used by the tutorial

[aymanhab]

Can you check @jimmyDunne which renames are respected or not, I fixed Forces/Muscles, Constraint but there were others (Probe, Controller,..) that were converted later. Please provide specific list and I'll address. Thanks.

[jenhicks]

@apoorvar Is this needed for the tutorial? @jimmyDunne A reminder to respond to Ayman's question at some point.

[apoorvar]

No, the "isDisabled" flag isn't used in the tutorial.

[aymanhab]

Need to find all the "isDisabled" properties in 3.3 and see if they continue to function in 4.0.

[aseth1]

Verify that force, constraints, probes and controllers respond to their replacements for isDisabled

[aseth1]

@apoorvar can you confirm that the enabling/disabling capability of specific Components works as expected. These are:

• Forces: appliesForce
• Constraints: isEnforced
• Controllers: enabled

[aymanhab]

Probe::enabled has been fixed in PR #573

[aseth1]

Muscles: On latest Windows build multi-selecting all individual Muscles you get an Enable right-click option with a checked box. If you uncheck the box, then each Muscle gets a red prohibited 🚯 icon next to it and each muscle's appliesForce flag becomes unchecked (muscles do not disappear from visualizer as they did in 3.3). This takes ~45s on the drop landing model (49 muscles) which seems excessive. Re-enabling takes about the same amount of time.

Constraints: Top-level Constraints has Show/Hide options which doesn't apply to most (all) constraints to-date. Similar to muscles there is an Enable right-click option when multi-selecting constraints which is already checked. Unchecking Enable causes the isEnforced flag on each Constraint to be unchecked.

Need to find a Model with Probes and Controllers to verify these.

[jenhicks]

This one has probes: https://simtk-confluence.stanford.edu:8443/display/OpenSim/Simulation-Based+Design+to+Reduce+Metabolic+Cost

@jimmyDunne Do the associated files live somewhere on GitHub?

[jenhicks]

ToyLandingModel_AFO has controllers (In Models/ToyDropLanding)

[aseth1]

Controllers: When Enable is checked in the Navigator the the controllers' enabled property is also checked. Unchecking the Enable in the Navigator also unchecks the enabled property. Confirmed that they affect the simulation as expected. Co-contraction controllers reduce inversion. ✔️

[aseth1]

Probes: When Enable is checked in the Navigator the the probe's enabled property is also checked. Unchecking the Enable in the Navigator also unchecks the enabled property. When Probe Enble is unchecked, its values are excluded from the ProbeReporter results. ✔️

[aseth1]

@jenhicks we can move to verified since the GUI is responding to the new flags instead of the old (removed) isDisabled flag. The issues are now:

1. a mismatch with the Navigor Enable option with the appliesForce and isEnforced flags on the Forces and Constraints.
2. setting the flags on multiple objects (e.g. Forces/Muscles) is very slow

[jenhicks]

Thanks @aseth1 Can you make issues for the points you note above? I don't see existing issues.