{Tutorial 1} Muscle 'Show Only' changes the muscle color from blue to red

opensim-org / opensim-gui

SimTK OpenSim graphical user interface and distribution.

Apache License 2.0

62 stars 33 forks source link

{Tutorial 1} Muscle 'Show Only' changes the muscle color from blue to red #756

Open jimmyDunne opened 6 years ago

jimmyDunne commented 6 years ago

Steps to reproduce

Load gait2392
Expand muscle list
Right-click on a muscle group and select 'Show Only'

Expected result

Muscles selected are shown only and stay blue

Actual result

Muscles that are shown turn red. They return to the correct color, blue, when you move the motion slider.

ezgif com-video-to-gif

Environment and GUI version

Mac, OpenSim e07981e-2018-05-15

aymanhab commented 6 years ago

Let me explain why that's the case and I'd like to hear your thoughts:

When playing back a motion, muscles are colored from state (blue in this case)
If you do any editing (could be show/hide but could disable muscle or do something more significant) then we switch to whatever arbitrary colors stored with the model since the state could be invalidated. I think part of the problem is the default red-color that ties in users' minds to activation when in reality it means nothing unless showing results.

tkuchida commented 6 years ago

Seems like it might be necessary to treat some property edits differently from others. I can see invalidating the state if I edit a GeometryPath, for example, but I wouldn't expect any "collateral damage" if I just show/hide Components because the simulation is not affected by whether or not a geometry/mesh is drawn in the Visualizer.

chrisdembia commented 6 years ago

Similar issue in #859:

Do we agree that muscles should be drawn red when posed? I don't mind, since it reminds the user that it isn't a result of the simulation, but perhaps there is a better way to indicate that while leaving muscle states the same.