search

opensim-org / opensim-models

SimTK OpenSim models (.osim) and related example files that are distributed with OpenSim.
opensim.stanford.edu
60 stars 43 forks source link

Remove '_Simbody' from gait model names #75

Open jimmyDunne opened 6 years ago

jimmyDunne commented 6 years ago

I would like to remove the _simbody from gait2392 and gait2354. I'm sure there was a reasonable reason to differentiate them way back when, but now they are inconsistent from every other model— every model is a Simbody model.

This change would involve converting the (i) names of the models in the repo, (ii) setup files, and (iii) the Cmake lists. Externally I would update the documentation with the improved, shorter name.

I am looking for comment before I make a branch and do the conversions.

tkuchida commented 6 years ago

I agree with removing the "_simbody" suffix.

chrisdembia commented 6 years ago

I agree.

jimmyDunne commented 6 years ago

PR #79 has dealt with this.