search

opensim-org / opensim-viewer

Front end of web based viewer of OpenSim models, data
Apache License 2.0
13 stars 3 forks source link

Handle model change #101

Closed aymanhab closed 1 year ago

aymanhab commented 1 year ago

This change forces the camera to zoom-out/refocus the whole scene when a new model is loaded. Fixes issue #87

netlify[bot] commented 1 year ago

Deploy Preview for comforting-speculoos-d9e100 ready!

Name Link
Latest commit bbef89151c15228c63cff16c28175cd4ea34997c
Latest deploy log https://app.netlify.com/sites/comforting-speculoos-d9e100/deploys/6515edf5829f15000895e949
Deploy Preview https://deploy-preview-101--comforting-speculoos-d9e100.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AlbertoCasasOrtiz commented 1 year ago

I tested this locally and it works when I load new models, but when trying to open a pre-baked model from the model showcase it shows the model with no textures.

The only prebaked model that I managed to open properly at some point was MarkerData, but after exploring other models in the model showcase it is not showing anymore. It throws Could not load tile.jpg: undefined), but the file is present.

aymanhab commented 1 year ago

Packaged models will need to be recreated (through downloading gltf files so that annotations for layers and materials are regenerated with the latest defaults. That said the missing texture file is a bit harder to explain. Let me know how to help move this through and thanks for testing @AlbertoCasasOrtiz

aymanhab commented 1 year ago

@AlbertoCasasOrtiz When I wait on the build for a while it starts acting correctly with showing the floor and fog and using the updated leg39 and pendulum models. Did you have any luck running in dev mode to get to the source of the issue?

aymanhab commented 1 year ago

This was subsumed in the PR #105 so will close