search

opensim-org / opensim-viewer

Front end of web based viewer of OpenSim models, data
Apache License 2.0
13 stars 3 forks source link

Allow dropping GLTF files directly to test without backend #104

Closed aymanhab closed 1 year ago

aymanhab commented 1 year ago

Per our discussion @AlbertoCasasOrtiz

netlify[bot] commented 1 year ago

Deploy Preview for comforting-speculoos-d9e100 ready!

Name Link
Latest commit 8da5d6ee211993a2af976768d97a2beea9d68d61
Latest deploy log https://app.netlify.com/sites/comforting-speculoos-d9e100/deploys/6515cbaf679a490008520625
Deploy Preview https://deploy-preview-104--comforting-speculoos-d9e100.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AlbertoCasasOrtiz commented 1 year ago

@aymanhab It was still accessing to the backend and not loading the model, but I fixed it.

However, Jest is failing. I think I solved this in another PR by updating node version in CI to 16.

Also, in the case with no backend (gltf file), the progress bar is not updated since it has not feedback from axios.

AlbertoCasasOrtiz commented 1 year ago

@aymanhab I just solved the problem with CI by updating node version to 16. This is the same error I had in the charting library PR and it is caused because one of the dependencies we are using is not compatible with node 12.