search

opensim-org / opensim-viewer

Front end of web based viewer of OpenSim models, data
Apache License 2.0
13 stars 3 forks source link

embed gltf_url in viewer url #137

Closed aymanhab closed 11 months ago

aymanhab commented 11 months ago

The goal here is to be able to share the view with a single link, so the receiver can view, navigate the model and animations without having to explicitly visit the viewer site or log in.

netlify[bot] commented 11 months ago

Deploy Preview for grand-clafoutis-85edb2 failed.

Name Link
Latest commit 2280e6a4868e5115062a047e0eff5ff76f8630d5
Latest deploy log https://app.netlify.com/sites/grand-clafoutis-85edb2/deploys/6578f6a8018bba0008b830c2
netlify[bot] commented 11 months ago

Deploy Preview for comforting-speculoos-d9e100 failed.

Name Link
Latest commit 2280e6a4868e5115062a047e0eff5ff76f8630d5
Latest deploy log https://app.netlify.com/sites/comforting-speculoos-d9e100/deploys/6578f6a8cfef9e0008b593e0
aymanhab commented 11 months ago

As of now refreshing the page or sharing the link doesn't work. Investigating

aymanhab commented 11 months ago

@AlbertoCasasOrtiz I fixed this so that when you upload a file you can share the url with others without login, please try this URL https://fix-url-mapping.d7iaa9a9lxtm6.amplifyapp.com/viewer/https%3A%2F%2Fs3.us-west-2.amazonaws.com%2Fopensim-viewer-public-download%2Fbouncing_block.gltf

AlbertoCasasOrtiz commented 11 months ago

Looks like it is working, I can see the bouncing_block.gltf model.

aymanhab commented 11 months ago

Perfect, thank you. If you can review that would be great to merge into master.

aymanhab commented 11 months ago

Thanks @AlbertoCasasOrtiz will merge this and open an issue to address the viewer button separately (basically it has a hardcoded link to /viewer regardless of context, need to be context aware)