search

opensistemas-hub / osbrain

osBrain - A general-purpose multi-agent system module written in Python
https://osbrain.readthedocs.io/en/stable/
Apache License 2.0
176 stars 43 forks source link

Complete docstrings #227

Closed ocaballeror closed 6 years ago

ocaballeror commented 6 years ago

In response to #179

Edit: fixes #179.

codecov[bot] commented 6 years ago

Codecov Report

Merging #227 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          26       26           
  Lines        3438     3438           
  Branches      246      246           
=======================================
  Hits         3405     3405           
  Misses         22       22           
  Partials       11       11
Impacted Files Coverage Δ
osbrain/logging.py 100% <ø> (ø) :arrow_up:
osbrain/nameserver.py 99.2% <ø> (ø) :arrow_up:
osbrain/proxy.py 100% <ø> (ø) :arrow_up:
osbrain/agent.py 97.51% <ø> (ø) :arrow_up:
osbrain/address.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a03cdd0...eddf83c. Read the comment docs.

Peque commented 6 years ago

Looks good to me. :blush:

Peque commented 6 years ago

@ocaballeror Remember to push changes to the PR before merging into master. It is safer and that way the PR gets automatically closed once you merge. :wink:

BTW: for future commits try not to use past sentence in the commit messages (i.e.: start with "Add, update, implement..." instead of "Added, updated, implemented..."). I forgot to check that in the review. :sweat_smile: