Closed Peque closed 5 years ago
Merging #236 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #236 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 26 26
Lines 3602 3602
Branches 261 261
=======================================
Hits 3575 3575
Misses 15 15
Partials 12 12
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5c1c4b0...0344cb3. Read the comment docs.
Is it really necessary to support a development version of python? The final release is not supposed to be released until June this year.
There probably won't be any incompatibilities, there's no need to rush this 😁 .
@ocaballeror Sure, it is marked as WIP and assigned to milestone 0.7.0. We will not be merging this until 3.7 is out, but wanted to check compatibility before final release.
Although unlikely, major releases come with many changes and might break something. Better to spot it early and report it if that is the case. The fact that we are using 3.4.4
in Travis is actually an example of 3.4.3
being broken (in this case a broken minor release). Checking all minor releases before they are out is not worth it, but major releases are worth it in my opinion (fortunately they do not occur very often).
you'll have to use "3.7-dev" for travis because they only have an old 3.7 beta version available right now
@irmen Thanks! :blush:
Yeah, we used that during the 3.7 beta to make sure the new version did not break anything. Not that we are in a hurry, so we will probably wait until 3.7
is available in Travis (hope it wont take too long!). :joy:
By the way, if you want to use 3.7 now I think you can, but you need to use sudo: true
and dist: xenial
in your travis.yml
file. A bit of a hack... :sweat_smile:
@ocaballeror It seems they finally made Xenial available in Travis. It was about time! :joy:
For now this is just to see if everything seems to work fine with 3.7 development branch.It seems everything works fine with Python 3.7.
Update (2018-07-24)
Waiting for Python 3.7 to be available on Travis: https://github.com/travis-ci/travis-ci/issues/9815