Add linger parameter to `.close()` and `.close_all()`

opensistemas-hub / osbrain

osBrain - A general-purpose multi-agent system module written in Python

https://osbrain.readthedocs.io/en/stable/

Apache License 2.0

176 stars 43 forks source link

Add linger parameter to `.close()` and `.close_all()` #255

Open ocaballeror opened 6 years ago

ocaballeror commented 6 years ago

As mentioned in https://github.com/opensistemas-hub/osbrain/pull/252#issuecomment-368051072

This is mostly for Windows compatibility, since it won't support changing the linger value in the global config dictionary.

By the way, this also needs tests for both methods.

Peque commented 6 years ago

Yeah, let us not work on this issue for now. Maybe we can fix the global configuration problem instead.

Peque commented 6 years ago

There is #256 now, so i am moving this to milestone 0.8.0.

Note that this change would probably require not only adding more tests, but also allowing to pass a linger parameter to other method calls such as .shutdown() (and more tests, of course). So I am not sure it is worth it.

Anyway, let us discuss this for 0.8.0 instead. :stuck_out_tongue_winking_eye: