Closed Peque closed 6 years ago
Merging #270 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #270 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 26 26
Lines 3532 3532
Branches 252 252
=======================================
Hits 3498 3498
Misses 21 21
Partials 13 13
Impacted Files | Coverage Δ | |
---|---|---|
...ain/tests/test_agent_sync_publications_handlers.py | 98.27% <100%> (ø) |
:arrow_up: |
osbrain/tests/test_agent_sync_publications.py | 100% <100%> (ø) |
:arrow_up: |
osbrain/proxy.py | 100% <100%> (ø) |
:arrow_up: |
osbrain/tests/test_agent_ipc_sockets.py | 100% <100%> (ø) |
:arrow_up: |
osbrain/tests/test_bugs.py | 100% <100%> (ø) |
:arrow_up: |
osbrain/tests/test_nameserver.py | 98.11% <100%> (ø) |
:arrow_up: |
osbrain/tests/test_agent_serialization.py | 100% <100%> (ø) |
:arrow_up: |
...sbrain/tests/test_agent_async_requests_handlers.py | 96% <100%> (ø) |
:arrow_up: |
osbrain/tests/test_agent_async_requests.py | 100% <100%> (ø) |
:arrow_up: |
osbrain/tests/test_logging.py | 100% <100%> (ø) |
:arrow_up: |
... and 7 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 317fa51...0363f0a. Read the comment docs.
Pushed a fixup to recover colored output in AppVeyor.
Let's see if I understood this correctly.
You unified the list of testing dependencies between tox.ini
and requirements.txt
, and removed tox from it. Now users are supposed to install it manually, hence the modification on .appveyor.yml
. Correct?
If that's the case, maybe we should mention it in the documentation, don't you think?
I basically moved all dependencies to setup.py
. Just like before there where some docs
dependencies declared, now there are some test
dependencies declared too. It is a better approach in my opinion. tox
is actually not a required dependency for running/passing the tests locally. It is simply very convenient.
I just pushed a commit updating the documentation.