Closed Peque closed 6 years ago
Merging #272 into master will increase coverage by
0.11%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
+ Coverage 99.03% 99.15% +0.11%
==========================================
Files 26 26
Lines 3532 3542 +10
Branches 252 256 +4
==========================================
+ Hits 3498 3512 +14
+ Misses 21 18 -3
+ Partials 13 12 -1
Impacted Files | Coverage Δ | |
---|---|---|
osbrain/tests/test_agent_serialization.py | 100% <100%> (ø) |
:arrow_up: |
osbrain/tests/test_agent_ipc_sockets.py | 100% <100%> (ø) |
:arrow_up: |
osbrain/tests/test_agent_req_rep.py | 100% <100%> (ø) |
:arrow_up: |
osbrain/tests/test_proxy.py | 100% <100%> (ø) |
:arrow_up: |
...ain/tests/test_agent_sync_publications_handlers.py | 98.27% <100%> (ø) |
:arrow_up: |
osbrain/tests/test_logging.py | 100% <100%> (ø) |
:arrow_up: |
osbrain/tests/test_agent_sync_publications.py | 100% <100%> (ø) |
:arrow_up: |
osbrain/tests/test_agent_pubsub_topics.py | 100% <100%> (ø) |
:arrow_up: |
osbrain/tests/test_nameserver.py | 98.11% <100%> (ø) |
:arrow_up: |
osbrain/tests/test_bugs.py | 100% <100%> (ø) |
:arrow_up: |
... and 10 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 317fa51...de2565a. Read the comment docs.
Thank you. I got tired of them from the moment we started integrating Appveyor.
Just one question, though, why so many commits?
@ocaballeror As I mentioned, this depends on #271 (it includes all commits in that PR). Note that #271 depends on #270 too, which means you might want to review #270 first, #271 then and lastly this PR.
Otherwise just review this PR, but take into account it is the sum of 3 PRs.
@ocaballeror Here again, the only relevant commit is the last one, all the others are already in master
.
It seems I am unable to change the "base" of this PR to the current master
. And I do not want to close and reopen the PR just for that... :joy:
The tests failed in travis, though. The error is not related to these commits at all, but still worth noticing nonetheless.
Yeah, I noticed. It is the already familiar ns.shutdown()
error... :sweat_smile:
@Peque Not this time. In this case it failed on agent.shutdown()
, which is kinda weird.
Depends on #271.
I kind of got tired of those email notifications... What you think?